Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use props for includes and remove global includes #3921

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Use props for includes and remove global includes #3921

merged 1 commit into from
Jan 4, 2024

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Jan 3, 2024

No description provided.

@byrnHDF byrnHDF added Merge - To 1.14 Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Component - Testing Code in test or testpar directories, GitHub workflows Component - Build CMake, Autotools Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub Type - Improvement Improvements that don't add a new feature or functionality Component - Misc Anything else (CODEOWNERS, etc.) labels Jan 3, 2024
@byrnHDF byrnHDF self-assigned this Jan 3, 2024
@lrknox lrknox merged commit a00d62f into HDFGroup:develop Jan 4, 2024
49 checks passed
@byrnHDF byrnHDF deleted the develop-includes branch January 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjala mattjala mattjala approved these changes

@vchoi-hdfgroup vchoi-hdfgroup vchoi-hdfgroup approved these changes

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@derobins derobins Awaiting requested review from derobins derobins is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol qkoziol is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees

@byrnHDF byrnHDF

Labels
Component - Build CMake, Autotools Component - Misc Anything else (CODEOWNERS, etc.) Component - Testing Code in test or testpar directories, GitHub workflows Priority - 0. Blocker ⛔ This MUST be merged for the release to happen Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@byrnHDF @jhendersonHDF @vchoi-hdfgroup @mattjala @lrknox